Re: [PATCH V3 2/2] ASoC: codecs: Add aw88166 amplifier driver

From: Markus Elfring
Date: Wed Mar 12 2025 - 10:01:29 EST



> The driver is for amplifiers aw88166 of Awinic Technology


You may occasionally put more than 57 characters into text lines
of such a change description.


See also:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc6#n94



> +++ b/sound/soc/codecs/aw88166.c
> @@ -0,0 +1,1933 @@

> +static void aw88166_startup_work(struct work_struct *work)
> +{

> + mutex_lock(&aw88166->lock);
> + aw88166_start_pa(aw88166);
> + mutex_unlock(&aw88166->lock);
> +}


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&aw88166->lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/mutex.h#L201

Regards,
Markus