Re: [PATCH] drm: xlnx: zynqmp_dpsub: fix Kconfig dependencies for ASoC

[Tomi Valkeinen]

Hi Arnd,

On 27/02/2025 15:20, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The new audio code fails to build when sounds support is in a loadable
> module but the GPU driver is built-in:
>
> x86_64-linux-ld: zynqmp_dp_audio.c:(.text+0x6a8): undefined reference to `devm_snd_soc_register_card'
> x86_64-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dp_audio.o:(.rodata+0x1bc): undefined reference to `snd_soc_info_volsw'
> x86_64-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dp_audio.o:(.rodata+0x1f0): undefined reference to `snd_soc_get_volsw'
> x86_64-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dp_audio.o:(.rodata+0x1f4): undefined reference to `snd_soc_put_volsw'
>
> Change the Kconfig dependency to disallow the sound support in this
> configuration.
>
> Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>   drivers/gpu/drm/xlnx/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig
> index dbecca9bdd54..cfabf5e2a0bb 100644
> --- a/drivers/gpu/drm/xlnx/Kconfig
> +++ b/drivers/gpu/drm/xlnx/Kconfig
> @@ -22,6 +22,7 @@ config DRM_ZYNQMP_DPSUB_AUDIO
>   	bool "ZynqMP DisplayPort Audio Support"
>   	depends on DRM_ZYNQMP_DPSUB
>   	depends on SND && SND_SOC
> +	depends on SND_SOC=y || DRM_ZYNQMP_DPSUB=m
>   	select SND_SOC_GENERIC_DMAENGINE_PCM
>   	help
>   	  Choose this option to enable DisplayPort audio support in the ZynqMP

Thanks, pushing to drm-misc-next.

 Tomi