Re: [PATCH net v1] netfilter: nf_conncount: Fully initialize struct nf_conncount_tuple in insert_tree()
From: Pablo Neira Ayuso
Date: Wed Mar 12 2025 - 10:36:52 EST
On Sun, Mar 09, 2025 at 05:07:38PM +0900, Kohei Enju wrote:
> Since commit b36e4523d4d5 ("netfilter: nf_conncount: fix garbage
> collection confirm race"), `cpu` and `jiffies32` were introduced to
> the struct nf_conncount_tuple.
>
> The commit made nf_conncount_add() initialize `conn->cpu` and
> `conn->jiffies32` when allocating the struct.
> In contrast, count_tree() was not changed to initialize them.
>
> By commit 34848d5c896e ("netfilter: nf_conncount: Split insert and
> traversal"), count_tree() was split and the relevant allocation
> code now resides in insert_tree().
> Initialize `conn->cpu` and `conn->jiffies32` in insert_tree().
Applied to nf.git, thanks