Re: [PATCH iwl-next v9 02/14] net: ethtool: mm: extract stmmac verification logic into common library

From: Vladimir Oltean
Date: Wed Mar 12 2025 - 11:37:12 EST


On Sun, Mar 09, 2025 at 06:46:36AM -0400, Faizal Rahim wrote:
> @@ -7850,7 +7850,7 @@ int stmmac_suspend(struct device *dev)
> rtnl_unlock();
>
> if (stmmac_fpe_supported(priv))
> - timer_shutdown_sync(&priv->fpe_cfg.verify_timer);
> + ethtool_mmsv_stop(&priv->fpe_cfg.mmsv);
>
> priv->speed = SPEED_UNKNOWN;
> return 0;

FWIW, this trivially conflicts with net-next commit 64fdb808660d ("net:
stmmac: remove write-only priv->speed").