Re: [PATCH v4 7/7] thermal: core: Record PSCR before hw_protection_shutdown()

[Daniel Lezcano]

On 12/03/2025 17:51, Oleksij Rempel wrote:
> Hi Daniel,
>
> On Wed, Mar 12, 2025 at 04:35:51PM +0100, Daniel Lezcano wrote:
> > > @@ -380,6 +381,8 @@ static void thermal_zone_device_halt(struct thermal_zone_device *tz, bool shutdo
> > >    	dev_emerg(&tz->device, "%s: critical temperature reached\n", tz->type);
> > > +	set_power_state_change_reason(PSCR_OVERTEMPERATURE);
> > > +
> > >    	if (shutdown)
> > >    		hw_protection_shutdown(msg, poweroff_delay_ms);
> > >    	else
> >
> > In the future could you add me as recipient to the series instead of this
> > one ? so I can get more context.
>
> ack.
>
> > Given there are no so much hw_protection_shutdown() users in the kernel, it
> > could be more interesting to change the function to receive a enum
> > pscr_reason and then in the hw_protection_shutdown() call
> > pscrr_reason_to_str().
>   
> Do you mean, make it work with CONFIG_PSCRR=n?

No I meant instead of doing:

+	set_power_state_change_reason(PSCR_OVERTEMPERATURE);
+
 	if (shutdown)
 		hw_protection_shutdown(msg, poweroff_delay_ms);

Replace it by:

 	if (shutdown)
 		hw_protection_shutdown(PSCR_OVERTEMPERATURE, poweroff_delay_ms);


and in hw_protection_shutdown() use pscrr_reason_to_str() to display a msg.

That can work with CONFIG_PSCRR=n


> Beside, the latest version is v5:
> https://lore.kernel.org/all/20250310103732.423542-1-o.rempel@xxxxxxxxxxxxxx/

Ah ok thanks for the pointer


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog