Re: [PATCH v2 5/7] scripts: generate_rust_analyzer.py: use str(pathlib.Path)
From: Fiona Behrens
Date: Wed Mar 12 2025 - 15:04:26 EST
Tamir Duberstein <tamird@xxxxxxxxx> writes:
> Use the `/` operator on `pathlib.Path` rather than directly crafting a
> string. This is consistent with all other path manipulation in this
> script.
>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
Reviewed-by: Fiona Behrens <me@xxxxxxxxxx>
> ---
> scripts/generate_rust_analyzer.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index c73ea8d116a4..1bb185ae2e87 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -109,7 +109,7 @@ def generate_crates(
> crate: ProcMacroCrate = {
> **crates[-1],
> "is_proc_macro": True,
> - "proc_macro_dylib_path": f"{objtree}/rust/{proc_macro_dylib_name}",
> + "proc_macro_dylib_path": str(objtree / "rust" / proc_macro_dylib_name),
> }
> crates[-1] = crate