Re: [PATCH v2 1/7] scripts: generate_rust_analyzer.py: add missing whitespace
From: Fiona Behrens
Date: Wed Mar 12 2025 - 15:10:49 EST
Tamir Duberstein <tamird@xxxxxxxxx> writes:
> Add a space before the `/` operator for consistency with surrounding
> code and code formatting tools. Add a second newline between top-level
> items in accordance with PEP 8[1]:
>
>> Surround top-level function and class definitions with two blank
> lines.
>
> This change was made by a code formatting tool.
>
> Link: https://peps.python.org/pep-0008/ [1]
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
Reviewed-by: Fiona Behrens <me@xxxxxxxxxx>
> ---
> scripts/generate_rust_analyzer.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index adae71544cbd..15a690ae2edb 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -103,7 +103,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs):
> ):
> append_crate(
> display_name,
> - srctree / "rust"/ display_name / "lib.rs",
> + srctree / "rust" / display_name / "lib.rs",
> deps,
> cfg=cfg,
> )
> @@ -178,5 +178,6 @@ def main():
>
> json.dump(rust_project, sys.stdout, sort_keys=True, indent=4)
>
> +
> if __name__ == "__main__":
> main()