Re: [PATCH v2 5/5] rust: enable `clippy::as_underscore` lint
From: Benno Lossin
Date: Wed Mar 12 2025 - 15:43:40 EST
On Wed Mar 12, 2025 at 8:19 PM CET, Tamir Duberstein wrote:
> I tried using the strict provenance lints locally and I think we can't
> until we properly bump MSRV due to `clippy::incompatible_msrv`:
>
> warning: current MSRV (Minimum Supported Rust Version) is `1.78.0` but
> this item is stable since `1.84.0`
> --> ../rust/kernel/str.rs:696:22
> |
> 696 | pos: pos.expose_provenance(),
> | ^^^^^^^^^^^^^^^^^^^
> |
> = help: for further information visit
> https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
Oh this is annoying...
> This is with `#![feature(strict_provenance)]`. I can file the issue
> but I think it's blocked on MSRV >= 1.84.0. But maybe you know of a
> path forward :)
I think we should be able to just `allow(clippy::incompatible_msrv)`,
since Miguel & other maintainers will test with 1.78 (or at least are
supposed to :).
---
Cheers,
Benno