Re: [PATCH v5 09/10] hyperv: Add definitions for root partition driver to hv headers

From: Nuno Das Neves
Date: Wed Mar 12 2025 - 16:18:35 EST


On 3/10/2025 5:40 AM, Tianyu Lan wrote:
> On Thu, Feb 27, 2025 at 7:11 AM Nuno Das Neves
> <nunodasneves@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> A few additional definitions are required for the mshv driver code
>> (to follow). Introduce those here and clean up a little bit while
>> at it.
>>
>> Signed-off-by: Nuno Das Neves <nunodasneves@xxxxxxxxxxxxxxxxxxx>
>> ---
>
> It may be better to unify data type u8, u16, u32, u64 or __u8, __u16,
> __u32, __u64 in the hvhdk.h.
>
Agreed, this was an oversight. They should all be the kernel types
without the __ prefix.

Thanks
Nuno

> Others like good.
>
> Reviewed-by: Tianyu Lan <tiala@xxxxxxxxxxxxx>
>