Re: [PATCH 1/4] mm/madvise: use is_memory_failure() from madvise_do_behavior()

[Shakeel Butt]

On Wed, Mar 12, 2025 at 09:47:47AM -0700, SeongJae Park wrote:
> To reduce redundant open-coded checks of CONFIG_MEMORY_FAILURE and
> MADV_{HWPOISON,SOFT_OFFLINE} in madvise_[un]lock(), is_memory_failure()
> is introduced.  madvise_do_behavior() is still doing the same open-coded
> check, though.  Use is_memory_failure() instead.
> 
> To avoid build failure on !CONFIG_MEMORY_FAILURE case, implement an
> empty madvise_inject_error() under the config.  Also move the definition
> of is_memory_failure() inside #ifdef CONFIG_MEMORY_FAILURE clause for
> madvise_inject_error() definition, to reduce duplicated ifdef clauses.
> 
> Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>

Reviewed-by: Shakeel Butt <shakeel.butt@xxxxxxxxx>