Re: [PATCH] igc: enable HW VLAN insertion/stripping by default
From: Tony Nguyen
Date: Wed Mar 12 2025 - 17:43:53 EST
On 3/11/2025 6:59 AM, Rui Salvaterra wrote:
Hi, Simon,
On Tue, 11 Mar 2025 at 13:52, Simon Horman <horms@xxxxxxxxxx> wrote:
Having looked over this I am also curious to know the answer to that question.
This does seem to be the default for other Intel drivers (at least).
Unfortunately, I'm unable check with the original author or those
involved at the time. From asking around it sounds like there may have
been some initial issues when implementing this; my theory is this was
off by default so that it would minimize the affects if additional
issues were discovered.
I see that you missed Intel Wired LAN (intel-wired-lan@xxxxxxxxxxxxxxxx)
on the patch. Could you resend with the list included? Also, if you
could make it 'PATCH iwl-next' to target the Intel -next tree as that
seems the appropriate tree.
Thanks,
Tony
Well, r8169 also enables it, and RealTek controllers are used everywhere. :)
Kind regards,
Rui Salvaterra