Re: [PATCH v1 1/1] mtd: mtdpart: Do not supply NULL to printf()

[Zhihao Cheng]

在 2025/3/13 4:16, Andy Shevchenko 写道:
> Compiler is not happy about NULL being supplied as printf() parameter:

printf -> printk? The title has the same issue.
> drivers/mtd/mtdpart.c:693:34: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
>
> Replace that with "(null)" to fix compilation error.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>   drivers/mtd/mtdpart.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index 6811a714349d..6f7e250ef710 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -691,7 +691,7 @@ int parse_mtd_partitions(struct mtd_info *master, const char *const *types,
>   			if (!parser && !request_module("%s", *types))
>   				parser = mtd_part_parser_get(*types);
>   			pr_debug("%s: got parser %s\n", master->name,
> -				parser ? parser->name : NULL);
> +				parser ? parser->name : "(null)");
>   			if (!parser)
>   				continue;
>   			ret = mtd_part_do_parse(parser, master, &pparts, data);