Re: [PATCH RFC v5 10/10] iomap: Rename ATOMIC flags again
From: Christoph Hellwig
Date: Thu Mar 13 2025 - 04:09:47 EST
On Thu, Mar 13, 2025 at 07:53:22AM +0000, John Garry wrote:
> > REQ_FUA is not defined for reads in Linux Some of the storage standards
> > define it for reads, but the semantics are pretty nonsensical.
> >
>
> ok, so I will need to check for writes when setting that (as it was
> previously)
Yes. That entire IOMAP_MAPPED branch should just grow and additional
IOMAP_DIO_WRITE check, as all the code in it is only relevant to writes.
In fact that also includes the most of the other checks before,
so this could use more refactoring if we want to.