Re: [PATCH 04/10] dt-bindings: riscv: Add SiFive HiFive Premier P550 board

[Samuel Holland]

Hi Krzysztof,

On 2025-03-12 7:55 AM, Krzysztof Kozlowski wrote:
> On 11/03/2025 08:34, Pinkesh Vaghela wrote:
>> From: Pritesh Patel <pritesh.patel@xxxxxxxxxxxxxx>
>>
>> Add DT binding documentation for the ESWIN EIC7700 SoC and
>> HiFive Premier P550 Board
>>
>> Signed-off-by: Pritesh Patel <pritesh.patel@xxxxxxxxxxxxxx>
>> Reviewed-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
> 
> 
> This Rb tag appears everywhere, while this is a v1 and it was not given
> on the lists, so I want to be sure this was not some blank tag added to
> series because someone said "yeah, lgtm". Was it really review as in
> *reviewers statement of oversight*?

Yes, to be clear, the series has my:

Reviewed-by: Samuel Holland <samuel.holland@xxxxxxxxxx>

per the reviewer’s statement of oversight.

Regards,
Samuel

>> Signed-off-by: Pinkesh Vaghela <pinkesh.vaghela@xxxxxxxxxxxxxx>
>> ---
> ..
> 
> 
>> +
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 25c86f47353d..901d0e0adb25 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -8572,6 +8572,12 @@ L:	linux-can@xxxxxxxxxxxxxxx
>>  S:	Maintained
>>  F:	drivers/net/can/usb/esd_usb.c
>>  
>> +ESWIN DEVICETREES
>> +M:	Min Lin <linmin@xxxxxxxxxxxxxxxxxx>
>> +M:	Pinkesh Vaghela <pinkesh.vaghela@xxxxxxxxxxxxxx>
>> +M:	Pritesh Patel <pritesh.patel@xxxxxxxxxxxxxx>
>> +S:	Maintained
> 
> If you add this entry here, then add the path for the eswin binding.
> 
> Best regards,
> Krzysztof