Re: [PATCH 1/2] ARM: Require linker to support KEEP within OVERLAY for DCE

[Linus Walleij]

On Tue, Mar 11, 2025 at 8:43 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:

> ld.lld prior to 21.0.0 does not support using the KEEP keyword within an
> overlay description, which may be needed to avoid discarding necessary
> sections within an overlay with '--gc-sections', which can be enabled
> for the kernel via CONFIG_LD_DEAD_CODE_DATA_ELIMINATION.
>
> Disallow CONFIG_LD_DEAD_CODE_DATA_ELIMINATION without support for KEEP
> within OVERLAY and introduce a macro, OVERLAY_KEEP, that can be used to
> conditionally add KEEP when it is properly supported to avoid breaking
> old versions of ld.lld.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Link: https://github.com/llvm/llvm-project/commit/381599f1fe973afad3094e55ec99b1620dba7d8c
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>

Very clear and easy to follow.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij