Re: [PATCH v1] platform/x86: intel_pmc_ipc: add option to build without ACPI

[Choong Yong Liang]

On 12/3/2025 10:00 pm, Andy Shevchenko wrote:
> On Wed, Mar 12, 2025 at 1:23 PM Choong Yong Liang
> <yong.liang.choong@xxxxxxxxxxxxxxx> wrote:
> > On 12/3/2025 3:54 pm, Andy Shevchenko wrote:
> > > On Wed, Mar 12, 2025 at 4:30 AM Choong Yong Liang
> > > <yong.liang.choong@xxxxxxxxxxxxxxx> wrote:
>
> ...
>
> > Thank you for your detailed feedback and suggestions. I'll make the
> > necessary adjustments to the patch based on your comments above.
> >
> > > > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> > > > Signed-off-by: Choong Yong Liang <yong.liang.choong@xxxxxxxxxxxxxxx>
> > >
> > > This is wrong as either it's a wrong tag (SoB --> Suggested-by?), or
> > > missing Co-developed-by, or wrong order (but in that case David should
> > > have sent the patch).
> > I believe the sequence is still correct, as the solution was provided by
> > David, and he should be the main author. I'm just the submitter, so my
> > sign-off should be placed last.
>
> You are the submitter *and* the author in this case. As I said, that
> SoB chain is wrong in its current form.
Hi Andy,

I believe this time I have correctly attributed the authorship by following 
the guide from:
https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
---
From: David E. Box <david.e.box@xxxxxxxxxxxxxxx>

<changelog>

Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
Co-developed-by: Choong Yong Liang <yong.liang.choong@xxxxxxxxxxxxxxx>
Signed-off-by: Choong Yong Liang <yong.liang.choong@xxxxxxxxxxxxxxx>
---