Re: [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P
From: Ayushi Makhija
Date: Thu Mar 13 2025 - 05:05:09 EST
On 3/12/2025 5:15 PM, Krzysztof Kozlowski wrote:
> On Tue, Mar 11, 2025 at 05:54:38PM +0530, Ayushi Makhija wrote:
>> Document DSI controller and phy on SA8775P platform.
>>
>> Signed-off-by: Ayushi Makhija <quic_amakhija@xxxxxxxxxxx>
>> ---
>> .../display/msm/qcom,sa8775p-mdss.yaml | 188 ++++++++++++++++++
>> 1 file changed, 188 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>> index a90a8b3f1a9e..628ca68871f4 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>> @@ -52,6 +52,26 @@ patternProperties:
>> items:
>> - const: qcom,sa8775p-dp
>>
>> + "^dsi@[0-9a-f]+$":
>> + type: object
>> + additionalProperties: true
>> +
>
> Drop blank line
>
>> + properties:
>> + compatible:
>> + items:
>
> contains
>
>> + - const: qcom,sa8775p-dsi-ctrl
>> + - const: qcom,mdss-dsi-ctrl
>
> Drop fallback
>
> Same comments further
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
Thanks, for the review.
Will address the above comments in the next patch.
+ "^dsi@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sa8775p-dsi-ctrl
+ - qcom,mdss-dsi-ctrl
+
+ "^phy@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sa8775p-dsi-phy-5nm
+ - qcom,sa8775p-edp-phy
Thanks,
Ayushi