Re: [PATCH v2] genirq: Fix parameter type in declaration and definition

[Thomas Gleixner]

On Thu, Mar 13 2025 at 15:30, ye xingchen wrote:
> From: YeXingchen <ye.xingchen@xxxxxxxxxx>
>
> The declaration of irq_set_irqchip_state in the header file uses
> bool state as the parameter type, while the definition uses bool val.

What's the problem?

> This patch aligns the parameter name in the definition with the

git grep 'This patch' Documentation/process/

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
>   *	interrupt controller has per-cpu registers.
>   */
>  int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> -			  bool val)
> +			  bool state)
>  {
>  	struct irq_desc *desc;
>  	struct irq_data *data;

This does not even compile....

So that clearly ensures consistency...