Re: [PATCH v2 1/1] mtd: mtdpart: Do not supply NULL to printf()

From: Andy Shevchenko
Date: Thu Mar 13 2025 - 09:58:06 EST


On Thu, Mar 13, 2025 at 09:09:09PM +0800, Zhihao Cheng wrote:
> 在 2025/3/13 17:15, Andy Shevchenko 写道:
> > GCC compiler is not happy about NULL being supplied as printf() parameter:
> >
> > drivers/mtd/mtdpart.c:693:34: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
> >
> > Move the code after the parser test for NULL, and drop the ternary completely.
> > The user can deduct this since when it's not NULL two messages will be printed.

> Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>

Thank you!

--
With Best Regards,
Andy Shevchenko