Re: [PATCH 1/2] mtd: rawnand: gpmi: Use str_enabled_disabled() in gpmi_nand_attach_chip()

[han.xu]

On 25/03/13 05:57PM, Zhang Heng wrote:
> [You don't often get email from zhangheng@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Signed-off-by: Zhang Heng <zhangheng@xxxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index d76802944453..f4e68008ea03 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -17,6 +17,7 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/dma/mxs-dma.h>
> +#include <linux/string_choices.h>
>  #include "gpmi-nand.h"
>  #include "gpmi-regs.h"
>  #include "bch-regs.h"
> @@ -2319,8 +2320,8 @@ static int gpmi_nand_attach_chip(struct nand_chip *chip)
>                                           "fsl,no-blockmark-swap"))
>                         this->swap_block_mark = false;
>         }
> -       dev_dbg(this->dev, "Blockmark swapping %sabled\n",
> -               this->swap_block_mark ? "en" : "dis");
> +       dev_dbg(this->dev, "Blockmark swapping %s\n",
> +               str_enabled_disabled(this->swap_block_mark));

Reviewed-by: Han Xu <han.xu@xxxxxxx>

> 
>         ret = gpmi_init_last(this);
>         if (ret)
> --
> 2.47.1
>