Re: [PATCH 4/6] ARM: dts: qcom: sdx75: Add QPIC NAND support

From: Konrad Dybcio
Date: Thu Mar 13 2025 - 10:39:33 EST


On 3/13/25 2:09 PM, Kaushal Kumar wrote:
> Add devicetree node to enable support for QPIC
> NAND controller on Qualcomm SDX75 platform.
> Since there is no "aon" clock in SDX75, a dummy
> clock is provided.

Alter the bindings not to require it then, instead

[...]

>
> + qpic_nand: nand-controller@1cc8000 {
> + compatible = "qcom,sdx75-nand", "qcom,sdx55-nand";
> + reg = <0x0 0x01cc8000 0x0 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&rpmhcc RPMH_QPIC_CLK>,
> + <&nand_clk_dummy>;
> + clock-names = "core", "aon";
> +
> + dmas = <&qpic_bam 0>,
> + <&qpic_bam 1>,
> + <&qpic_bam 2>;
> + dma-names = "tx", "rx", "cmd";

Please make dma-names a vertical list, just like dmas

Konrad