Re: [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and definition

From: Jeff Johnson
Date: Thu Mar 13 2025 - 11:53:06 EST


On 3/13/2025 1:01 AM, ye.xingchen@xxxxxxxxxx wrote:
> From: YeXingchen <ye.xingchen@xxxxxxxxxx>
>
> The declaration of utf32_to_utf8 in the header file uses
> bool maxlen as the parameter type, while the definition uses bool maxout.
>
> This patch aligns the parameter name in the definition with the
> declaration,changing maxout to maxlen to ensure consistency.
>
> Signed-off-by: YeXingchen <ye.xingchen@xxxxxxxxxx>
> ---
> fs/nls/nls_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nls/nls_base.c b/fs/nls/nls_base.c
> index 18d597e49a19..1dc2f8c8916e 100644
> --- a/fs/nls/nls_base.c
> +++ b/fs/nls/nls_base.c
> @@ -83,7 +83,7 @@ int utf8_to_utf32(const u8 *s, int inlen, unicode_t *pu)
> }
> EXPORT_SYMBOL(utf8_to_utf32);
>
> -int utf32_to_utf8(unicode_t u, u8 *s, int maxout)
> +int utf32_to_utf8(unicode_t u, u8 *s, int maxlen)
> {
> unsigned long l;
> int c, nc;

It is obvious you didn't compile this code since the implementation still uses
maxout. Note that a less intrusive change would be to rename parameters in the
prototype.