Re: [PATCH v2 3/4] mm/mempolicy: Enable sysfs support for memory hotplug in weighted interleave

[Gregory Price]

On Thu, Mar 13, 2025 at 03:34:10PM +0900, Rakie Kim wrote:
> On Wed, 12 Mar 2025 12:14:48 -0400 Gregory Price <gourry@xxxxxxxxxx> wrote:
> 
> Given that this adjustment is part of integrating the refactored
> structure, I believe this patch does not need to be split into two.
> However, I would appreciate any further input you may have on this.
>

Another way of saying this is: can you please change the ordering of
patch 2 and 3 and place the functional changes into "make mempolicy
support memory hotplug" patch.

It's a little odd to "make mempolicy support memory hotplug" and then
follow that up with a patch that says "now make it REALLY support it".

Patch 2 should read:
   "Refactor weighted_interleave sysfs to allow node structure to be
    dynamic"
Patch 3 should read:
   "Make weighted interleave sysfs structure support memory hotplug"

I think you'll find the patches end up looking much cleaner this way as
well.

~Gregory