Re: [PATCH v2 2/2] ACPI: PNP: Add Intel OC Watchdog IDs to non-PNP device list

[Diogo Ivo]

On 3/13/25 3:29 PM, Rafael J. Wysocki wrote:
> Hi,
>
> On Thu, Mar 13, 2025 at 11:28 AM Diogo Ivo <diogo.ivo@xxxxxxxxxxx> wrote:
> > Hi Rafael,
> >
> > On 3/12/25 7:31 PM, Rafael J. Wysocki wrote:
> > > On Wed, Mar 12, 2025 at 4:46 PM Diogo Ivo <diogo.ivo@xxxxxxxxxxx> wrote:
> > > > With the kernel having an ACPI driver for these watchdog devices add
> > > > their IDs to the known non-PNP device list. Note that this commit is
> > > > not a complete list of all the possible watchdog IDs.
> > > >
> > > > Signed-off-by: Diogo Ivo <diogo.ivo@xxxxxxxxxxx>
> > > > ---
> > > >    drivers/acpi/acpi_pnp.c | 2 ++
> > > >    1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > > > index 01abf26764b00c86f938dea2ed138424f041f880..3f5a1840f573303c71f5d579e32963a5b29d2587 100644
> > > > --- a/drivers/acpi/acpi_pnp.c
> > > > +++ b/drivers/acpi/acpi_pnp.c
> > > > @@ -355,8 +355,10 @@ static bool acpi_pnp_match(const char *idstr, const struct acpi_device_id **matc
> > > >     * device represented by it.
> > > >     */
> > > >    static const struct acpi_device_id acpi_nonpnp_device_ids[] = {
> > > > +       {"INT3F0D"},
> > > >           {"INTC1080"},
> > > >           {"INTC1081"},
> > > > +       {"INTC1099"},
> > > >           {""},
> > > >    };
> > > >
> > > >
> > > > --
> > >
> > > Is there a particular reason for this patch?
> >
> > Yes, since the ACPI tables for these watchdogs have both a PNP0C02 CID and
> > and then an HID (such as INT3F0D or INTC1099) without this patch the driver
> > in patch 01 will not bind to the device because PNP will bind to it first.
> > My understanding is that this table was added to solve exactly this problem
> > so I added these HIDs here, but if this is wrong and I misunderstood
> > please let me know.
>
> You are right, but the above information is missing from the
> changelog.  Please add it there.

I'll add it and send v3 after receiving feedback on the other patch in
the series.

Best regards,
Diogo