RE: [PATCH] x86/Hyperv: Fix check of return value from snp_set_vmsa()

[Michael Kelley]

From: Tianyu Lan <ltykernel@xxxxxxxxx> Sent: Thursday, March 13, 2025 1:52 AM
> 
> snp_set_vmsa() returns 0 as success result and so fix it.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 44676bb9d566 ("x86/hyperv: Add smp support for SEV-SNP guest")
> Signed-off-by: Tianyu Lan <tiala@xxxxxxxxxxxxx>
> ---
>  arch/x86/hyperv/ivm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> index ec7880271cf9..77bf05f06b9e 100644
> --- a/arch/x86/hyperv/ivm.c
> +++ b/arch/x86/hyperv/ivm.c
> @@ -338,7 +338,7 @@ int hv_snp_boot_ap(u32 cpu, unsigned long start_ip)
>  	vmsa->sev_features = sev_status >> 2;
> 
>  	ret = snp_set_vmsa(vmsa, true);
> -	if (!ret) {
> +	if (ret) {
>  		pr_err("RMPADJUST(%llx) failed: %llx\n", (u64)vmsa, ret);
>  		free_page((u64)vmsa);
>  		return ret;
> --
> 2.25.1
> 

Yes, with this change the code is now consistent with other call sites for
snp_set_vmsa() and for direct invocation of rmpadjust().

Reviewed-by: Michael Kelley <mhklinux@xxxxxxxxxxx>