Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function

From: Artur Weber
Date: Thu Mar 13 2025 - 16:39:18 EST


On 13.03.2025 14:25, Mark Brown wrote:
On Thu, Mar 13, 2025 at 01:20:36PM +0000, Lee Jones wrote:
On Tue, 04 Mar 2025, Artur Weber wrote:

+ if (id != bcm590xx->pmu_id) {
+ dev_err(bcm590xx->dev,
+ "Incorrect ID for %s: expected %x, got %x. Check your DT compatible.\n",

Isn't it more likely that the H/W this is being executed on is
unsupported? If so, say that instead.

Given that the compatibles are device specific the driver shouldn't be
binding if the device is unsupported.

Yes, the intention here is just to make sure that the DT compatible and
hardware ID match. Unsupported hardware would not have a DT compatible.

Best regards
Artur