Re: [PATCH] cxl/acpi: Add Null check for adev

[Dan Williams]

Chenyuan Yang wrote:
> Not all devices have an ACPI companion fwnode, so adev might be NULL.
> This is similar to the commit cd2fd6eab480 ("platform/x86: int3472:
> Check for adev == NULL"). 

No, please do not consume review bandwidth with patches like this.

Read the full commit you referenced it explicitly states the failing
condition:

"This can e.g. (theoretically) happen when a user manually binds one of
the int3472 drivers to another i2c/platform device through sysfs."

Then think through whether that theoretical condition applies to the
cxl_acpi driver and the ACPI0017 device.