Re: [PATCH v3 10/13] i2c: xgene-slimpro: Simplify PCC shared memory region handling
From: Andi Shyti
Date: Thu Mar 13 2025 - 20:48:42 EST
Hi Sudeep,
On Thu, Mar 13, 2025 at 03:28:56PM +0000, Sudeep Holla wrote:
> The PCC driver now handles mapping and unmapping of shared memory
> areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> this xgene-slimpro I2C driver did handling of those mappings like several
> other PCC mailbox client drivers.
>
> There were redundant operations, leading to unnecessary code. Maintaining
> the consistency across these driver was harder due to scattered handling
> of shmem.
>
> Just use the mapped shmem and remove all redundant operations from this
> driver.
>
> Cc: Andi Shyti <andi.shyti@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
Acked-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Thanks,
Andi