Re: [PATCH v2 4/4] mm/mempolicy: Fix duplicate node addition in sysfs for weighted interleave
From: Rakie Kim
Date: Fri Mar 14 2025 - 02:36:07 EST
On Thu, 13 Mar 2025 12:42:03 -0400 Gregory Price <gourry@xxxxxxxxxx> wrote:
> On Wed, Mar 12, 2025 at 04:56:27PM +0900, Rakie Kim wrote:
> > Sysfs attributes for interleave control were registered both at initialization
> > and when new nodes were detected via hotplug, leading to potential duplicates.
> >
> > This patch ensures that each node is registered only once, preventing conflicts
> > and redundant sysfs entries.
> >
>
> After looking more closely at patch 2, this seems to suggest we're not
> understanding the OFFLINE/ONLINE events well enough to use for this
> purpose. I think this patch won't be needed once we address the
> concerns in patch 2 - and more generally if we discover it is needed
> this should just be rolled into patch 2 rather than kept separate.
>
> ~Gregory
For this patch, it might be beneficial to merge it with another patch
or change its form. I will consider the changes, including the feedback
from Joshua.
Rakie