Re: [PATCH v3] USB: serial: ftdi_sio: add support for Altera USB Blaster 3
From: Johan Hovold
Date: Fri Mar 14 2025 - 03:24:11 EST
On Fri, Mar 14, 2025 at 02:14:47AM +0000, Ng, Boon Khai wrote:
> > Thanks for the update, now applied.
> >
> > Next time, remember to put your SoB above the (first) cut-off line (---) so that
> > it is included in the commit message when your patch is applied.
> > I fixed that up manually this time.
>
> Thank you for your feedback and for applying the update.
> I apologize for the misunderstanding regarding the placement of the SoB.
> I mistakenly thought I needed to create the cut-off line myself in the
> commit message.
No worries.
> I now understand that I should generate the patch first and then
> manually add the change log under the first cut-off line that
> appears below the sign-off.
That's what I do, but if you add your SoB followed by a cut-off line and
change log to your local commit, then that should also work if you later
run git-format-patch.
Johan