Re: [PATCH 1/2] dt-bindings: mailbox: cix: add device tree binding documentation.

From: Guomin chen
Date: Fri Mar 14 2025 - 04:23:44 EST


On Fri, Mar 14, 2025 at 08:25:40AM +0100, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On 13/03/2025 14:24, Guomin Chen wrote:
> > From: Guomin Chen <Guomin.Chen@xxxxxxxxxxx>
> >
> > This patch adds device tree binding for mailbox from Cixtech.
> >
> > Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxxx>
> > Signed-off-by: Lihua Liu <Lihua.Liu@xxxxxxxxxxx>
> > Signed-off-by: Guomin Chen <Guomin.Chen@xxxxxxxxxxx>
>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
>
> Best regards,
> Krzysztof

Thank you for your hint. Although I have used scripts/get_maintainer.pl to
obtain the cc list, I do lack devicetree@xxxxxxxxxxxxxxx
I will copy it in the next version. Thank you very much.

Best regards,
Guomin Chen