Re: [PATCH v7 06/10] iio: adc: Support ROHM BD79124 ADC

[Matti Vaittinen]

On 14/03/2025 09:31, Matti Vaittinen wrote:
> On 13/03/2025 15:19, Andy Shevchenko wrote:
> > On Thu, Mar 13, 2025 at 09:19:03AM +0200, Matti Vaittinen wrote:

> > > +static int bd79124_chan_init(struct bd79124_data *data, int channel)
> > > +{
> > > +    int ret;
> > > +
> > > +    ret = regmap_write(data->map, 
> > > BD79124_GET_HIGH_LIMIT_REG(channel), 4095);
> >
> > BD79124_HIGH_LIMIT_MAX ?
> >
> > > +    if (ret)
> > > +        return ret;
> > > +
> > > +    return regmap_write(data->map, 
> > > BD79124_GET_LOW_LIMIT_REG(channel), 0);
> >
> > BD79124_HIGH_LIMIT_MIN ?
>
> I think I originally had these defines but I was probably asked to drop 
> the defines and use raw values instead.

Please ignore my reply here! It seems I still have the defines in other 
places of the code so they haven't been dropped after all. I'll replace 
the raw values as you suggested.

Thanks.

Yours,
	-- Matti