Re: RE: [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR_ACTIVE when resume has no issue
From: Marc Kleine-Budde
Date: Fri Mar 14 2025 - 05:53:50 EST
On 14.03.2025 09:48:06, Bough Chen wrote:
> > > > Only set CAN state to CAN_STATE_ERROR_ACTIVE when resume process has
> > > > no issue, otherwise keep in CAN_STATE_SLEEPING as suspend did.
> > >
> > > When looking at the code, it makes no sense to set the can.state to
> > > CAN_STATE_ERROR_ACTIVE, if the device isn't up.
> > >
> > > The suspend function doesn't look correct, either. I'll send a v3.
> >
> > After a suspend/resume cycle on a down interface, it will come up as
> > ERROR-ACTIVE.
>
> Seems only need to handle the priv->can.state when netif_running(dev) return true in PM.
ACK - in both the suspend and the resume function.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature