Re: [PATCH] soc: hisilicon: kunpeng_hccs: Fix incorrect string assembly
From: Jonathan Cameron
Date: Fri Mar 14 2025 - 06:02:49 EST
On Fri, 14 Mar 2025 16:28:56 +0800
Huisong Li <lihuisong@xxxxxxxxxx> wrote:
> String assembly should use sysfs_emit_at() instead of sysfs_emit().
>
> Signed-off-by: Huisong Li <lihuisong@xxxxxxxxxx>
Fixes tag?
Otherwise looks good to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
> drivers/soc/hisilicon/kunpeng_hccs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
> index 8aa8dec14911..444a8f59b7da 100644
> --- a/drivers/soc/hisilicon/kunpeng_hccs.c
> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
> @@ -1539,8 +1539,8 @@ static ssize_t used_types_show(struct kobject *kobj,
> u16 i;
>
> for (i = 0; i < hdev->used_type_num - 1; i++)
> - len += sysfs_emit(&buf[len], "%s ", hdev->type_name_maps[i].name);
> - len += sysfs_emit(&buf[len], "%s\n", hdev->type_name_maps[i].name);
> + len += sysfs_emit_at(buf, len, "%s ", hdev->type_name_maps[i].name);
> + len += sysfs_emit_at(buf, len, "%s\n", hdev->type_name_maps[i].name);
>
> return len;
> }