Re: [PATCH v2] ACPI: NUMA: debug invalid unused PXM value for CFMWs

[Jonathan Cameron]

On Thu, 13 Mar 2025 11:02:37 -0400
Gregory Price <gourry@xxxxxxxxxx> wrote:

> On Thu, Mar 13, 2025 at 02:09:07PM +0800, Yuquan Wang wrote:
> > @@ -441,6 +441,11 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
> >  	start = cfmws->base_hpa;
> >  	end = cfmws->base_hpa + cfmws->window_size;
> >  
> > +	if (srat_disabled()) {
> > +		pr_err("SRAT is missing or bad while processing CFMWS.\n");
> > +		return -EINVAL;
> > +	}
> > +  
> 
> I thought the srat was optional regardless of the presence of a CFMWS.
> Is this not the case?

True in theory, but do we want to support it?

I'd vote no unless someone is shipping such a system and can't fix it up.

Jonathan


> 
> ~Gregory
>