Re: [PATCH 06/14] ASoC: mediatek: mt8196: support audio GPIO control

[Linus Walleij]

Hi Darren,

thanks for your patch!

On Fri, Mar 7, 2025 at 1:49 PM Darren.Ye <darren.ye@xxxxxxxxxxxx> wrote:

> From: Darren Ye <darren.ye@xxxxxxxxxxxx>
>
> Implement mode switching for audio GPIO.
>
> Signed-off-by: Darren Ye <darren.ye@xxxxxxxxxxxx>

> +#include <linux/gpio.h>

Please don't include this legacy header. I don't think you even need it,
you are not using any gpio_ symbols at all.

> +#include <linux/pinctrl/consumer.h>

You don't seem to use anything from this include either.

Find more specific headers if you need the code to compile.

I think you should drop both, the name "GPIO" in this file is a bit confusing
because it's not very generic but dealing with audio IO routing. But I guess
it is what Mediatek calls it.

Yours,
Linus Walleij