Re: [PATCH] gpiolib: don't allow setting values on input lines

From: Bartosz Golaszewski
Date: Fri Mar 14 2025 - 06:35:42 EST


On Fri, Mar 14, 2025 at 11:33 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Mar 11, 2025 at 3:20 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > Some drivers as well as the character device and sysfs code check
> > whether the line actually is in output mode before allowing the user to
> > set a value.
> >
> > However, GPIO value setters now return integer values and can indicate
> > failures. This allows us to move these checks into the core code.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Makes sense, if there are regressions let's smoke them out
> in linux-next.
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks. I decided not to queue it for v6.15 for exactly that reason,
I'll pick it up early into the v6.16 cycle and let it sit in next for
several weeks.

Bart