RE: [PATCH v2 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support

[Kevin Chen]

> On 04/03/2025 11:44, Kevin Chen wrote:
> > The AST2600 has PCC controller in LPC, placed in LPC node.
> >
> > Signed-off-by: Kevin Chen <kevin_chen@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > index 8ed715bd53aa..87dcacb78692 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > @@ -626,6 +626,13 @@ lpc_snoop: lpc-snoop@80 {
> >  					status = "disabled";
> >  				};
> >
> > +				lpc_pcc: lpc-pcc@0 {
> > +					compatible = "aspeed,ast2600-lpc-pcc";
> > +					reg = <0x0 0x140>;
> > +					interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>;
> > +					status = "disabled";
> 
> Incomplete. Your driver clearly bails on missing ports...
Agree.

> 
> Best regards,
> Krzysztof