Re: [PATCH 1/2] tcp: fix races in tcp_abort()
From: Greg KH
Date: Fri Mar 14 2025 - 08:26:31 EST
On Fri, Mar 14, 2025 at 06:24:45PM +0900, Youngmin Nam wrote:
> From: Eric Dumazet <edumazet@xxxxxxxxxx>
>
> tcp_abort() has the same issue than the one fixed in the prior patch
> in tcp_write_err().
>
> commit 5ce4645c23cf5f048eb8e9ce49e514bababdee85 upstream.
>
> To apply commit bac76cf89816bff06c4ec2f3df97dc34e150a1c4,
> this patch must be applied first.
>
> In order to get consistent results from tcp_poll(), we must call
> sk_error_report() after tcp_done().
>
> We can use tcp_done_with_error() to centralize this logic.
>
> Fixes: c1e64e298b8c ("net: diag: Support destroying TCP sockets.")
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Acked-by: Neal Cardwell <ncardwell@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20240528125253.1966136-4-edumazet@xxxxxxxxxx
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v5.10+
Did not apply to 5.10.y, what did you want this added to?
thanks,
greg k-h