Re: [PATCH v3 1/2] can: flexcan: only change CAN state when link up in system PM
From: Marc Kleine-Budde
Date: Fri Mar 14 2025 - 08:27:59 EST
On 14.03.2025 19:01:44, haibo.chen@xxxxxxx wrote:
> From: Haibo Chen <haibo.chen@xxxxxxx>
>
> After a suspend/resume cycle on a down interface, it will come up as
> ERROR-ACTIVE.
>
> $ ip -details -s -s a s dev flexcan0
> 3: flexcan0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN group default qlen 10
> link/can promiscuity 0 allmulti 0 minmtu 0 maxmtu 0
> can state STOPPED (berr-counter tx 0 rx 0) restart-ms 1000
>
> $ sudo systemctl suspend
>
> $ ip -details -s -s a s dev flexcan0
> 3: flexcan0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN group default qlen 10
> link/can promiscuity 0 allmulti 0 minmtu 0 maxmtu 0
> can state ERROR-ACTIVE (berr-counter tx 0 rx 0) restart-ms 1000
>
> And only set CAN state to CAN_STATE_ERROR_ACTIVE when resume process
> has no issue, otherwise keep in CAN_STATE_SLEEPING as suspend did.
>
> Fixes: 4de349e786a3 ("can: flexcan: fix resume function")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
Applied to linux-can.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature