Re: [PATCH net-next 4/4] net/mlx5e: Expose port reset cycle recovery counter via ethtool
From: Stanislav Fomichev
Date: Fri Mar 14 2025 - 10:31:42 EST
On 03/13, Tariq Toukan wrote:
> From: Yael Chemla <ychemla@xxxxxxxxxx>
>
> Display recovery event of PPCNT recovery counters group. Counts (per
> link) the number of total successful recovery events of any recovery
> types during port reset cycle.
>
> Signed-off-by: Yael Chemla <ychemla@xxxxxxxxxx>
> Reviewed-by: Cosmin Ratiu <cratiu@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> ---
> .../ethernet/mellanox/mlx5/counters.rst | 5 +++
> .../ethernet/mellanox/mlx5/core/en_stats.c | 44 ++++++++++++++++---
> .../ethernet/mellanox/mlx5/core/en_stats.h | 4 ++
> 3 files changed, 48 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> index 99d95be4d159..f9a1cf370b5a 100644
> --- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> +++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> @@ -1082,6 +1082,11 @@ like flow control, FEC and more.
> need to replace the cable/transceiver.
> - Error
>
> + * - `total_success_recovery_phy`
> + - The number of total successful recovery events of any type during
> + ports reset cycle.
> + - Error
> +
html build complains with the following:
Sphinx parallel build error:
docutils.utils.SystemMessagePropagation: <system_message level="3" line="896" source="/home/doc-build/testing/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst" type="ERROR"><paragraph>Error parsing content block for the "flat-table" directive: exactly one bullet list expected.</paragraph><literal_block xml:space="preserve">.. flat-table:: Physical Port Counter Table
https://netdev-3.bots.linux.dev/doc-build/results/32382/stderr
The indent is wrong?
* - xx
- xx
- xx
Vs yours:
* - xx
- xx
- xx
---
pw-bot: cr