[PATCH] tracing: fix build without CONFIG_MODULES
From: Arnd Bergmann
Date: Fri Mar 14 2025 - 11:51:05 EST
From: Arnd Bergmann <arnd@xxxxxxxx>
The tracing code fails to build when CONFIG_MODULES is disabled:
kernel/trace/trace.c: In function 'save_mod':
kernel/trace/trace.c:6041:45: error: invalid use of undefined type 'struct module'
6041 | entry->mod_addr = (unsigned long)mod->mem[MOD_TEXT].base;
| ^~
The problem here is that 'struct module' is not defined in this configuration.
Enclose the functions in another #ifdef, just like other parts of this file
already are.
Fixes: dca91c1c5468 ("tracing: Have persistent trace instances save module addresses")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
kernel/trace/trace.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a6105b6dcc2b..51c030b9887e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -6019,6 +6019,7 @@ struct trace_scratch {
static DEFINE_MUTEX(scratch_mutex);
+#ifdef CONFIG_MODULES
static int save_mod(struct module *mod, void *data)
{
struct trace_array *tr = data;
@@ -6043,6 +6044,7 @@ static int save_mod(struct module *mod, void *data)
return 0;
}
+#endif
static void update_last_data(struct trace_array *tr)
{
@@ -6060,7 +6062,9 @@ static void update_last_data(struct trace_array *tr)
tscratch->nr_entries = 0;
guard(mutex)(&scratch_mutex);
+#ifdef CONFIG_MODULES
module_for_each_mod(save_mod, tr);
+#endif
}
if (!(tr->flags & TRACE_ARRAY_FL_LAST_BOOT))
--
2.39.5