Re: [PATCH v4 4/5] ASoC: qdsp6: q6apm-dai: set 10 ms period and buffer alignment.

[Johan Hovold]

On Fri, Mar 14, 2025 at 02:32:19PM +0000, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> 
> DSP expects the periods to be aligned to fragment sizes, currently
> setting up to hw constriants on periods bytes is not going to work
> correctly as we can endup with periods sizes aligned to 32 bytes however
> not aligned to fragment size.
> 
> Update the constriants to use fragment size, and also set at step of
> 10ms for period size to accommodate DSP requirements of 10ms latency.
> 
> Fixes: 9b4fe0f1cd79 ("ASoC: qdsp6: audioreach: add q6apm-dai support")

For all of the patches, if the intention is that they should be
backported to stable they should have a CC stable tag here.

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
>  sound/soc/qcom/qdsp6/q6apm-dai.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c
> index 90cb24947f31..a636f9280645 100644
> --- a/sound/soc/qcom/qdsp6/q6apm-dai.c
> +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c
> @@ -231,7 +231,6 @@ static int q6apm_dai_prepare(struct snd_soc_component *component,
>  	cfg.bit_width = prtd->bits_per_sample;
>  	cfg.fmt = SND_AUDIOCODEC_PCM;
>  	audioreach_set_default_channel_mapping(cfg.channel_map, runtime->channels);
> -

nit: unrelated change

>  	if (prtd->state) {
>  		/* clear the previous setup if any  */
>  		q6apm_graph_stop(prtd->graph);

Johan