Re: [PATCH v2 0/7] x86/entry: Break up common.c

[Sohil Mehta]

On 3/14/2025 8:12 AM, Brian Gerst wrote:
> The syscall dispatch code originally was put into entry/common.c so that
> common code for entry from and exit to userspace could be inlined.  That
> entry code has since been moved to the core kernel.  There is no longer
> a need to keep this code together, so move it to more appropriate
> places.
> 
> No functional changes.
> 
> Changes in v2:
> - Move Xen inlines to enlighten_pv.c (Juergen Gross)
> - Don't copy comments on the code's origins.  Git history has that
>   information already (Sohil Mehta)
> - Added cleanup patches (Sohil Mehta)
> 
> Brian Gerst (7):
>   x86/xen: Move Xen upcall handler
>   x86/syscall/32: Move 32-bit syscall dispatch code
>   x86/syscall/64: Move 64-bit syscall dispatch code
>   x86/syscall/x32: Move x32 syscall table
>   x86/syscall: Move sys_ni_syscall()
>   x86/syscall: Remove stray semicolons
>   x86/syscall/32: Add comment to conditional
> 

This series looks good to me. The minor comments in patch 7 can be
addressed separately if they seem useful.

Reviewed-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>


>  arch/x86/entry/Makefile      |   8 +-
>  arch/x86/entry/common.c      | 524 -----------------------------------
>  arch/x86/entry/syscall_32.c  | 332 +++++++++++++++++++++-
>  arch/x86/entry/syscall_64.c  | 111 +++++++-
>  arch/x86/entry/syscall_x32.c |  25 --
>  arch/x86/kernel/process.c    |   5 +
>  arch/x86/xen/enlighten_pv.c  |  69 +++++
>  7 files changed, 515 insertions(+), 559 deletions(-)
>  delete mode 100644 arch/x86/entry/common.c
>  delete mode 100644 arch/x86/entry/syscall_x32.c
> 
> 
> base-commit: d08c0d55110b7cbac186e5fa94b0c6d5f4d7905e