Re: [PATCH v9 0/6] scanf: convert self-test to KUnit

From: Kees Cook
Date: Fri Mar 14 2025 - 16:46:04 EST


On Fri, Mar 14, 2025 at 02:29:40PM +0100, Petr Mladek wrote:
> On Fri 2025-03-07 06:27:33, Tamir Duberstein wrote:
> > This is one of just 3 remaining "Test Module" kselftests (the others
> > being bitmap and printf), the rest having been converted to KUnit. In
> > addition to the enclosed patch, please consider this an RFC on the
> > removal of the "Test Module" kselftest machinery.
> >
> > Tamir Duberstein (6):
> > scanf: implicate test line in failure messages
> > scanf: remove redundant debug logs
> > scanf: convert self-test to KUnit
> > scanf: break kunit into test cases
>
> Kees, could you please take the above 5 patches as well
> via the tree moving the KUNIT tests to lib/tests ?

I think you mean 4? Sure!

-Kees

>
> They seem to be ready for linux-next and the next merge window.
>
> > scanf: tidy header `#include`s
>
> This one is a bit controversial and might be added later.
>
> > scanf: further break kunit into test cases
>
> This one was just an attempt. But I personally think that
> it is not worth it.
>
> Best Regards,
> Petr

--
Kees Cook