Re: [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all
From: Elizabeth Figura
Date: Fri Mar 14 2025 - 18:14:10 EST
On Friday, 14 March 2025 02:14:51 CDT Su Hui wrote:
> When 'manual=false' and 'signaled=true', then expected value when using
> NTSYNC_IOC_CREATE_EVENT should be greater than zero. Fix this typo error.
>
> Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
> ---
> tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c
> index 3aad311574c4..bfb6fad653d0 100644
> --- a/tools/testing/selftests/drivers/ntsync/ntsync.c
> +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c
> @@ -968,7 +968,7 @@ TEST(wake_all)
> auto_event_args.manual = false;
> auto_event_args.signaled = true;
> objs[3] = ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args);
> - EXPECT_EQ(0, objs[3]);
> + EXPECT_LE(0, objs[3]);
>
> wait_args.timeout = get_abs_timeout(1000);
> wait_args.objs = (uintptr_t)objs;
>
Reviewed-by: Elizabeth Figura <zfigura@xxxxxxxxxxxxxxx>