[RFC PATCH 2/2] selftests/timers: Improve skew_consistency by testing with other clockids

From: John Stultz
Date: Fri Mar 14 2025 - 20:38:27 EST


Lei Chen reported a bug with CLOCK_MONOTONIC_COARSE having
inconsistencies when NTP is adjusting the clock frequency.

This has gone seemingly undetected for ~15 years, illustrating a
clear gap in our testing.

The skew_consistency test is intended to catch this sort of
problem, but was focused on only evaluating CLOCK_MONOTONIC, and
thus missed the problem on CLOCK_MONOTONIC_COARSE.

So adjust the test to run with all clockids for 60 seconds each
instead of 10 minutes with just CLOCK_MONOTONIC.

Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
Cc: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>
Cc: Frederic Weisbecker <frederic@xxxxxxxxxx>
Cc: Shuah Khan <shuah@xxxxxxxxxx>
Cc: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
Cc: linux-kselftest@xxxxxxxxxxxxxxx
Cc: kernel-team@xxxxxxxxxxx
Cc: Lei Chen <lei.chen@xxxxxxxxxx>
Reported-by: Lei Chen <lei.chen@xxxxxxxxxx>
Closes: https://lore.kernel.org/lkml/20250310030004.3705801-1-lei.chen@xxxxxxxxxx/
Signed-off-by: John Stultz <jstultz@xxxxxxxxxx>
---
tools/testing/selftests/timers/skew_consistency.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
index 83450145fe657..46c391d7f45dc 100644
--- a/tools/testing/selftests/timers/skew_consistency.c
+++ b/tools/testing/selftests/timers/skew_consistency.c
@@ -47,7 +47,7 @@ int main(int argc, char **argv)

pid = fork();
if (!pid)
- return system("./inconsistency-check -c 1 -t 600");
+ return system("./inconsistency-check -t 60");

ppm = 500;
ret = 0;
--
2.49.0.rc1.451.g8f38331e32-goog