[PATCH linux-next] genirq: use sysfs_emit() instead of scnprintf().

From: xie.ludan
Date: Sat Mar 15 2025 - 02:17:35 EST


From: XieLudan <xie.ludan@xxxxxxxxxx>


Follow the advice in Documentation/filesystems/sysfs.rst:

show() should only use sysfs_emit() or sysfs_emit_at() when formatting

the value to be returned to user space.


Signed-off-by: XieLudan <xie.ludan@xxxxxxxxxx>

---

 kernel/irq/irqdesc.c | 12 ++++++------

 1 file changed, 6 insertions(+), 6 deletions(-)


diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c

index 287830739783..8ffe12fe5af6 100644

--- a/kernel/irq/irqdesc.c

+++ b/kernel/irq/irqdesc.c

@@ -257,11 +257,11 @@ static ssize_t per_cpu_count_show(struct kobject *kobj,

  for_each_possible_cpu(cpu) {

  unsigned int c = irq_desc_kstat_cpu(desc, cpu);

 

- ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%u", p, c);

+ ret += sysfs_emit(buf + ret, "%s%u", p, c);

  p = ",";

  }

 

- ret += scnprintf(buf + ret, PAGE_SIZE - ret, "\n");

+ ret += sysfs_emit(buf + ret, "\n");

  return ret;

 }

 IRQ_ATTR_RO(per_cpu_count);

@@ -274,7 +274,7 @@ static ssize_t chip_name_show(struct kobject *kobj,

 

  raw_spin_lock_irq(&desc->lock);

  if (desc->irq_data.chip && desc->irq_data.chip->name) {

- ret = scnprintf(buf, PAGE_SIZE, "%s\n",

+ ret = sysfs_emit(buf, "%s\n",

  desc->irq_data.chip->name);

  }

  raw_spin_unlock_irq(&desc->lock);

@@ -337,7 +337,7 @@ static ssize_t name_show(struct kobject *kobj,

 

  raw_spin_lock_irq(&desc->lock);

  if (desc->name)

- ret = scnprintf(buf, PAGE_SIZE, "%s\n", desc->name);

+ ret = sysfs_emit(buf, "%s\n", desc->name);

  raw_spin_unlock_irq(&desc->lock);

 

  return ret;

@@ -354,14 +354,14 @@ static ssize_t actions_show(struct kobject *kobj,

 

  raw_spin_lock_irq(&desc->lock);

  for_each_action_of_desc(desc, action) {

- ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%s",

+ ret += sysfs_emit(buf + ret, "%s%s",

  p, action->name);

  p = ",";

  }

  raw_spin_unlock_irq(&desc->lock);

 

  if (ret)

- ret += scnprintf(buf + ret, PAGE_SIZE - ret, "\n");

+ ret += sysfs_emit(buf + ret, "\n");

 

  return ret;

 }

-- 

2.25.1