Re: [PATCH v2] media: dt-bindings: Convert Analog Devices ad5820 to DT schema

From: David Heidelberg
Date: Sat Mar 15 2025 - 09:19:12 EST




On 14/03/2025 21:57, Sakari Ailus wrote:
Hi David,

Thanks for converting this to YAML.

On Fri, Mar 14, 2025 at 08:58:27PM +0100, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <david@xxxxxxx>

Convert the Analog Devices ad5820 to DT schema format.

Add the previously undocumented io-channel-cells property,
which can be omitted. If present, it must be set to 0,
as the device provides only one channel.

What's the purpose of this property? The driver doesn't use it nor I think
it provides any information on the hardware either. The above description
also appears to be saying it's redundant.

Hello Sakari,

from my understanding, you're right.

I would prefer to drop it, see [1].

Anyway from reading of documentation I understood it may be right to have the property empty, but also may be omitted. I saw both approaches in the code.

If you choose not liking this redudancy, I push [1] and drop the property here.

David



[1] https://patchwork.kernel.org/project/linux-omap/patch/20250213203208.93316-1-david@xxxxxxx/

--
David Heidelberg