Re: [PATCH] x86/asm: Use alternative_input() in amd_clear_divider()

[Borislav Petkov]

On Sat, Mar 15, 2025 at 10:29:25PM +0100, Ingo Molnar wrote:
> So why does the higher level alternative_input() API exist? If it 
> shouldn't exist then we should remove it. If it exists, we should use 
> it consistently instead of open-coding its equivalent.
> 
> Cleanups like this, especially if they are clearly part of an effort to 
> improve x86 code generation in this area, are not 'code churn', why 
> would they be?

Because this is not improving anything, IMO. It is simply writing it
differently, perhaps obscuring it more in the process.

And I, just like hpa, would need to go look at alternative_input() to figure
out what really happens there.

Dunno, maybe we should really remove alternative_input() instead...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette